On Wed, 8 Jan 2025 00:54:02 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Minor changes based on review. Copyright date adjustments. >> >> Co-authored-by: Martin Balao Alonso <mba...@redhat.com> >> Co-authored-by: Francisco Ferrari Bihurriet <fferr...@redhat.com> > > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line > 552: > >> 550: String P11Signature = "sun.security.pkcs11.P11Signature"; >> 551: String P11PSSSignature = >> "sun.security.pkcs11.P11PSSSignature"; >> 552: String P11KDF = "sun.security.pkcs11.P11KDF"; > > `P11KDF` should be `P11HKDF` with the latest renaming, i.e. both the var name > and the class name. That's right. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22215#discussion_r1906255801
