On Tue, 14 Jan 2025 00:51:05 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Renaming of P11KDF fix. >> >> Co-authored-by: Martin Balao Alonso <mba...@redhat.com> >> Co-authored-by: Francisco Ferrari Bihurriet <fferr...@redhat.com> > > test/jdk/sun/security/pkcs11/KDF/TestHKDF.java line 69: > >> 67: // knownBytes with AES/CBC/PKCS5Padding and an IV of 16 zero >> bytes. >> 68: // - If derivedKeyAlg is Generic, expectedOpOut is the result of >> 69: // calculating the HmacSHA256 of knownBytes. > > nit: mentioning these operations are done using the resulting `derivedKey`? Yes, it would help when reading the test for the first time, addressed in 699683e54a660c9a4950aafa819194cf9912accc. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22215#discussion_r1913997221
