On Wed, 8 Jan 2025 16:57:59 GMT, Mark Powers <mpow...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> no more combined output
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line
> 1245:
>
>> 1243: if ((legacyAlg & 8) == 8) {
>> 1244: warnings.add(String.format(
>> 1245:
>> rb.getString("The.1.signing.key.has.a.keysize.of.2.which.is.considered.a.security.risk..This.key.size.will.be.disabled.in.a.future.update."),
>
> Just pointing out that replacement by index is the convention for this block
> of code. Mixing in replacement by variable name seems strange, but maybe
> that's the future direction of this code. This is just a nit.
Thanks for pointing this out. Yes, I would like to use the new style more.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22735#discussion_r1907741615
