On Thu, 9 Jan 2025 19:19:11 GMT, Hai-May Chao <hc...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> no more combined output > > src/java.base/share/classes/sun/security/tools/keytool/Main.java line 2074: > >> 2072: * Note: the same method appears in keytool and jarsigner which >> uses >> 2073: * same resource string defined in their own Resources.java. >> 2074: * > > This method appears in both keytool and jarsigner as documented here. Can we > define a common method in KeyUtil class, which can return "size" and "alg", > in order for its caller to construct its display? I prefer to consolidate the logic in a single location. A record containing `size` and `alg` doesn’t seem to carry clear semantic meaning. Additionally, the `alg` field here has already been modified and does not solely represent the algorithm name. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22735#discussion_r1909628245
