On Fri, 17 Jan 2025 19:35:59 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve TestContext note about expectedOpOut
>>
>> Co-authored-by: Martin Balao Alonso <mba...@redhat.com>
>> Co-authored-by: Francisco Ferrari Bihurriet <fferr...@redhat.com>
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java
> line 198:
>
>> 196: CK_ATTRIBUTE.SIGN_TRUE};
>> 197:
>> 198: P12MacPBEKeyInfo(String algo, long kdfMech, HMACKeyInfo hmacKi)
>> {
>
> Maybe I'm missing something. Why this change? At least on the software side,
> we're leaving PBE algs untouched.
Just making use of newer classes, I suppose.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22215#discussion_r1920661057
