On Sat, 1 Feb 2025 04:20:36 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
> I need a review of this change that adds new timing controls for the initial
> server setup. On rare occasions, more so on certain architectures, the
> server may not fully start before the client tries to connect. Additional
> debugging is added to help identify if there are other timing issues.
>
> Thanks
>
> Tony
test/jdk/javax/net/ssl/templates/TLSBase.java line 204:
> 202: write(sock, read(sock));
> 203: } catch (Exception e) {
> 204: System.err.println("Caught " + e.getMessage());
`e.printStackTrace()` will include the exception message. Do we need this line
at all?
test/jdk/sun/security/ssl/SSLSessionImpl/MultiNSTParallel.java line 76:
> 74: String name = Thread.currentThread().getName();
> 75: SSLSession r;
> 76: System.err.println(name + " is ready");
This test is printing some things to System.out and some to System.err. It's
also using TLSBase which is printing everything to System.err. This will make
the logs difficult to read and understand.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23407#discussion_r1960004985
PR Review Comment: https://git.openjdk.org/jdk/pull/23407#discussion_r1960025280
