On Fri, 14 Feb 2025 15:07:50 GMT, Weijun Wang <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed to use a scratch directory
>
> test/jdk/sun/security/pkcs11/Provider/MultipleLogins.java line 63:
>
>> 61: private static final SunPKCS11[] providers = new
>> SunPKCS11[NUM_PROVIDERS];
>> 62:
>> 63: private static void copyDbFiles() throws IOException {
>
> We have existing utility method for this at
> https://github.com/openjdk/jdk/blob/a49f8332edc7da2a9494cd0dc96e5aa7271d9883/test/jdk/sun/security/pkcs11/PKCS11Test.java#L846.
We are looking to refactor the PKCS11Test.java, this will be addressed then. I
will hold this review until we decide the right approach.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23590#discussion_r1970272381
