On Wed, 19 Mar 2025 18:08:40 GMT, Mikhail Yankelevich
<myankelev...@openjdk.org> wrote:
>> Moved the sh file logic to jtreg java test.
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> minor: space at the end
test/jdk/sun/security/pkcs11/Provider/MultipleLogins.java line 75:
> 73: for (int i = 0; i < NUM_PROVIDERS; i++) {
> 74: // loop to set up test without security manger
> 75: providers[i] = (SunPKCS11)newPKCS11Provider();
Not sure if it's worth updating, but since `configure` always returns a new
provider, there is no need to call `newPKCS11Provider` here and we can just
call `configure` on the same `Security.getProvider("SunPKCS11")`. Also, you can
use the public `AuthProvider` instead of internal class `SunPKCS11` everywhere.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23590#discussion_r2035495685
