On Thu, 6 Mar 2025 08:37:57 GMT, Jatin Bhateja <[email protected]> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added alignment to loop entries.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_sha3.cpp line 85:
>
>> 83: if (UseSHA3Intrinsics) {
>> 84: StubRoutines::_sha3_implCompress =
>> generate_sha3_implCompress(StubGenStubId::sha3_implCompress_id);
>> 85: StubRoutines::_double_keccak = generate_double_keccak();
>
> Should UseDilithiumIntrinsics guard double_keccak generation ?
No, that is more of a SHA3 thing, other algorithms can take advantage of it,
too (e.g. ML-KEM).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23860#discussion_r1983033331
