On Thu, 6 Mar 2025 19:27:12 GMT, Volodymyr Paprotski <vpaprot...@openjdk.org> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Accepted review comments. > > src/hotspot/cpu/x86/stubGenerator_x86_64_sha3.cpp line 426: > >> 424: __ subl( roundsLeft, 1); >> 425: >> 426: __ evmovdquw(xmm5, xmm0, Assembler::AVX_512bit); > > Is there a pattern here; that can be 'compacted' into a loop? Unfortunately, no. This loop body is imported from generate_sha3_implCompress() and doubled, as explained in the comment about 15 lines above. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23860#discussion_r2006455877
