On Thu, 6 Mar 2025 16:20:19 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Feedback from Mikhail
>
> test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java line 105:
>
>> 103: "supported_versions"),
>> 104: List.of("Plaintext before ENCRYPTION")),
>> 105: // ssltypo contains "ssl". Treat like "ssl"
>
> This is surprising behavior. We want it to behave as if there was no suffix
> after ssl?
yes, the javax.net.debug property doesn't specify any delimiter between
options. Quite strange. It's also had the historical behaviour of printing all
ssl details once the string property contains "ssl" with the exception that
"sslctx" may be present.
Might target more behavioural changes via the JDK-8044609 parent bug but for
now, this patch is mimimal to aid backporting to update releases.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23781#discussion_r1983720961
