On Thu, 10 Apr 2025 03:11:42 GMT, Bradford Wetmore <wetm...@openjdk.org> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporate latest review feedback > > Depending on the followup discussion of what `ssl` alone means. > > However, several suggestions below, one might help with test coverage. If > you take some/all, then I'll review again. Should be quick. Thanks for your review @bradfordwetmore - I've fixed up the test case as per your review comments. Breaking the test output logic into two maps sounds attractive but the logic isn't mutually exclusive for some of our debug options. In fact, the debug logic for sub-components is still broken and should be fixed up in the follow on 8044609 bug fix. The logger implementation is at odds with our help and docs menu. I have used a map to test for good/bad patterns but I've left the keys for those maps as user defined. this fixes up special handling of the "ssl" option and restores it to the older TLSv1.2 stack approach. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23781#issuecomment-2802627538
