On Fri, 7 Mar 2025 17:19:46 GMT, Sean Mullan <mul...@openjdk.org> wrote:

>> Anyone still cares about this comment?
>> 
>> I've tried `-Djava.security.debug=certpath:ocsp,verbose+timestamp` (which 
>> follows the grammar in this PR) and there is no timestamp shown. Obviously, 
>> it's broken into `certpath:ocsp` and `verbose+timestamp` at 
>> https://github.com/openjdk/jdk/blob/940aa7c4cf1bf770690660c8bb21fb3ddc5186e4/src/java.base/share/classes/sun/security/util/Debug.java#L192
>>  and the `+timestamp` modifier is not applied to the `certpath` option.
>
> I think we should look into it. I think we can handle this as a follow-on bug 
> so that we keep this issue just about the docs.

I’m not suggesting any source changes, but this documentation update explicitly 
states:
> Sub-options are specified by appending a ":" to the option, followed by a 
> list of one more sub-options separated by a comma.

This breaks existing usages. In fact, unless (as Seán C suggested) we drop the 
2 modifiers entirely and make them always on, I don’t see a good way to fix it 
later if we keep the current grammar.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23569#discussion_r1985576977

Reply via email to