On Wed, 26 Feb 2025 00:45:13 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same order. > > src/java.base/share/classes/java/security/Provider.java line 2268: > >> 2266: } >> 2267: } >> 2268: aliasKeys = Collections.unmodifiableMap(aliasKeys); > > if `aliases` are empty, then we can skip line 2261-2268 and no need to update > `aliasKeys`? Good. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22613#discussion_r2025508086
