On Wed, 26 Feb 2025 01:09:55 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same order. > > src/java.base/share/classes/java/security/Provider.java line 1654: > >> 1652: } >> 1653: >> 1654: // used as key in the serviceMap and legacyMap HashMaps > > This comment is obsolete with the new impl and should be updated. True. I'll remove the comment as it's used in many places. The comment was not adding much anyways and it is not worth it keeping it in sync. It's easier to just look uses of the class in the same file. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22613#discussion_r2025520475
