On Thu, 24 Apr 2025 23:23:50 GMT, Sergey Kuksenko <skukse...@openjdk.org> wrote:
> Benchmark modification/extension shouldn't affect the behavior of other > benchmarks. > Precisely: [JDK-8344144](https://bugs.openjdk.org/browse/JDK-8344144) > modified AESBench in that way, which caused significant changes in the > behavior of other benchmarks that extend AESBench. test/micro/org/openjdk/bench/javax/crypto/full/AESExtraBench.java line 59: > 57: > 58: @Setup > 59: public void setup() throws NoSuchAlgorithmException, > NoSuchPaddingException, InvalidKeyException, BadPaddingException, > IllegalBlockSizeException, InvalidAlgorithmParameterException, > InvalidParameterSpecException { Nitpick: do you think something like this would be easier to read? Suggestion: public void setup() throws NoSuchAlgorithmException, NoSuchPaddingException, InvalidKeyException, BadPaddingException, IllegalBlockSizeException, InvalidAlgorithmParameterException, InvalidParameterSpecException { test/micro/org/openjdk/bench/javax/crypto/full/AESExtraBench.java line 64: > 62: } > 63: > 64: // @Benchmark Nitpick: is this method and ` public byte[] decrypt()` intended to be commented out? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24863#discussion_r2060405666 PR Review Comment: https://git.openjdk.org/jdk/pull/24863#discussion_r2060364124
