On Fri, 25 Apr 2025 14:56:56 GMT, Mikhail Yankelevich
<myankelev...@openjdk.org> wrote:
>> Sergey Kuksenko has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update AESExtraBench.java
>
> test/micro/org/openjdk/bench/javax/crypto/full/AESExtraBench.java line 59:
>
>> 57:
>> 58: @Setup
>> 59: public void setup() throws NoSuchAlgorithmException,
>> NoSuchPaddingException, InvalidKeyException, BadPaddingException,
>> IllegalBlockSizeException, InvalidAlgorithmParameterException,
>> InvalidParameterSpecException {
>
> Nitpick: do you think something like this would be easier to read?
> Suggestion:
>
> public void setup() throws NoSuchAlgorithmException,
> NoSuchPaddingException,
> InvalidKeyException,
> BadPaddingException,
> IllegalBlockSizeException,
> InvalidAlgorithmParameterException,
> InvalidParameterSpecException {
I keep the previous code without changing it.
> test/micro/org/openjdk/bench/javax/crypto/full/AESExtraBench.java line 64:
>
>> 62: }
>> 63:
>> 64: // @Benchmark
>
> Nitpick: is this method and ` public byte[] decrypt()` intended to be
> commented out?
Thank you for pointing this out. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24863#discussion_r2060449026
PR Review Comment: https://git.openjdk.org/jdk/pull/24863#discussion_r2060448206
