On Tue, 29 Apr 2025 21:44:26 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
>> for the HKDF support from JCA/JCE providers.
>>
>> This is just code refactoring. Known-answer regression test for the internal
>> JSSE HKDF impl is removed as the test vectors are already covered by the
>> HKDF impl in SunJCE provider.
>>
>> Thanks in advance for the review~
>
> Valerie Peng has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add comment about not using the same HKDF instance.
src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java line
837:
> 835: private static SecretKey deriveBinderKey(HandshakeContext context,
> 836: SecretKey psk, SSLSessionImpl session) throws IOException {
> 837: SecretKey earlySecret = null;
unused variable, can delete.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24393#discussion_r2068860887
