On Thu, 8 May 2025 20:40:28 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview features does >> not permanently define the API and it is subject to change in future >> releases until it is finalized. >> >> Details about this change can be seen at [PEM API >> JEP](https://bugs.openjdk.org/browse/JDK-8300911). >> >> Thanks >> >> Tony > > Anthony Scarpino has updated the pull request incrementally with three > additional commits since the last revision: > > - comments > - toString update > - non-sealed > Better X509 KeyPair parsing src/java.base/share/classes/java/security/PEMDecoder.java line 66: > 64: * For decode methods that accept a {@code Class<S> tClass} as input, > they can > 65: * modify the return type to a specific {@code DEREncodable} subclass. > 66: * For example, {@code ECPublicKey.class} can be used to cast a The "modify" and "cast" words seem to reveal some implementation detail. It's just "parsing the input as the specified type". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2082244995
