On Thu, 8 May 2025 20:40:28 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview features does >> not permanently define the API and it is subject to change in future >> releases until it is finalized. >> >> Details about this change can be seen at [PEM API >> JEP](https://bugs.openjdk.org/browse/JDK-8300911). >> >> Thanks >> >> Tony > > Anthony Scarpino has updated the pull request incrementally with three > additional commits since the last revision: > > - comments > - toString update > - non-sealed > Better X509 KeyPair parsing src/java.base/share/classes/java/security/PEMRecord.java line 51: > 49: * reached the end of the stream. If there is PEM data, {@code type} and > 50: * {@code pem} will both be non-null. {@code leadingData} may be null if > the > 51: * input data only contains PEM data. All values can never be null. It feels like the 2 paragraphs above should be in the spec of `Decoder::decode`. Here we only need to say what fields can be null. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2082643373
