On Thu, 29 May 2025 14:22:16 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 37 commits: >> >> - Merge branch 'master' into JDK-8341346 >> - Remove TlsExporterKeyingMaterial for now. Can add later if needed. >> - Merge branch 'master' into JDK-8341346 >> - Merge branch 'master' into JDK-8341346 >> - Added PKCS11 testing >> - Minor bug >> - Missed one change >> - Merge branch 'master' into JDK-8341346 >> - Private Codereview comment: Don't allow use of null keyAlgs, plus some >> minor cleanups >> - get*() no longer needed, backout error (oops!) >> - ... and 27 more: https://git.openjdk.org/jdk/compare/2ec6ab34...858362c8 > > test/jdk/javax/net/ssl/ExtendedSSLSession/ExportKeyingMaterialTests.java line > 1: > >> 1: /* > > Do you want to test about null/empty context difference in TLS 1.2/1.3? I can add that in the TLS1.2- arm, although I'm not sure it's really needed. Will fix. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24976#discussion_r2114839789
