On Sun, 22 Jun 2025 17:21:17 GMT, Koushik Muthukrishnan Thirupattur
<d...@openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains two commits:
>>
>> - Merge branch 'master' into JDK-8357470
>> - JDK-8357470: src/java.base/share/classes/sun/security/util/Debug.java
>> implement the test for args.toLowerCase
>>
>> * added an automated mixed case option
>> * using multithreading now
>> * added logs for simpler debug
>> * added missing -Djava.security.auth.debug coverage
>
> test/jdk/sun/security/util/Debug/DebugOptions.java line 152:
>
>> 150: * @return resulting string
>> 151: */
>> 152: private String makeFirstAndLastLetterUppercase(final String
>> paramString) {
>
> If the goal is to test case-insensitive parsing comprehensively, this method
> should be expanded to test various case combinations (e.g., all-uppercase,
> alternating case, etc). Otherwise, document this limitation.
As per our discussion, split this test into 3. upper case, mixed case and
lowercase. Done in the next commit
> test/jdk/sun/security/util/Debug/DebugOptions.java line 153:
>
>> 151: */
>> 152: private String makeFirstAndLastLetterUppercase(final String
>> paramString) {
>> 153: final int length = paramString.length();
>
> Edge Case : Can we check for null or empty before this ?
Done in the next commit
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25391#discussion_r2163549646
PR Review Comment: https://git.openjdk.org/jdk/pull/25391#discussion_r2163549856
