On Tue, 12 Aug 2025 19:21:20 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> finetune the spec > > src/java.base/share/classes/javax/crypto/spec/snippet-files/PackageSnippets.java > line 31: > >> 29: import java.security.KeyPairGenerator; >> 30: import java.util.Arrays; >> 31: > > Please put a short comment here explaining that the only purpose of this file > in to be displayed as a snippet in javadoc of `HPKEParameterSpec` class. Yes, I can add one. That said, I follow the same convention used in other parts of JDK (search for more `snippet-files/PackageSnippets.java`) and none of them has any comment. I think the naming already implies its purpose. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2271382753
