On Tue, 12 Aug 2025 21:50:44 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/DHKEM.java line 313:
>> 
>>> 311:                         return new SecretKeySpec(km, from, to - from, 
>>> alg);
>>> 312:                     }
>>> 313:                 } else if (fullKey instanceof SliceableSecretKey ssk) {
>> 
>> It would be nice to actually test this code as we currently don't have any 
>> implementation of `SliceableSecretKey`
>
> This interface is for PKCS #11 secret keys, where we won't be able to 
> directly get the full key material. There will be another PR for it. At the 
> moment, I can probably write a customized HKDF implementation. Let me try if 
> it's easy enough.

New test added in latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2271474002

Reply via email to