On Tue, 26 Aug 2025 14:17:16 GMT, Mikhail Yankelevich
<[email protected]> wrote:
>> test/jdk/sun/security/pkcs11/SecureRandom/Basic.java line 50:
>>
>>> 48: } catch (NoSuchAlgorithmException e) {
>>> 49: e.printStackTrace();
>>> 50: throw new SkippedException("Provider " + p + " does not
>>> support SecureRandom, skipping");
>>
>> If you add `e` as the cause here, you can probably get rid of the explicit
>> `e.printStackTrace()`
>
> It is set there on purpose. This way it will log to the `System.out` and not
> `System.err`. Just easier to spot this way. I can add `e` into skipped
> exception, but it seems to be a bit of an overkill. What do you think?
To me it would look logical to look in the `SkippedException` cause to find the
reason why the test was skipped, rather than looking somewhere in stdout
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26942#discussion_r2301235047
