On Tue, 19 Aug 2025 22:30:55 GMT, Valerie Peng <[email protected]> wrote:
>> Thomas Fitzsimmons has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - PKCS11Test.getNssConfig: Throw an exception if configuration file does
>> not exist
>> - PKCS11Test.getNssConfig: Expand comment about regular expression
>> - PKCS11Test.getNssConfig: Document CUSTOM_P11_CONFIG properties
>> - Initialize nss_library based on CUSTOM_P11_LIBRARY_NAME
>
> test/jdk/sun/security/pkcs11/PKCS11Test.java line 458:
>
>> 456:
>> 457: public static String getNssConfig() throws Exception {
>> 458: nss_library = System.getProperty("CUSTOM_P11_LIBRARY_NAME",
>> nss_library);
>
> Have you considered setting `nss_library` with the system property on line 92
> instead of here? E.g.
>
>> static String nss_library = System.getProperty("CUSTOM_P11_LIBRARY_NAME",
>> "softokn3");
>
> Setting it there is more visible and it's clear what the property is for.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26325#discussion_r2311310290
