On Wed, 20 Aug 2025 01:35:13 GMT, Valerie Peng <[email protected]> wrote:
>> Thomas Fitzsimmons has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - PKCS11Test.getNssConfig: Throw an exception if configuration file does
>> not exist
>> - PKCS11Test.getNssConfig: Expand comment about regular expression
>> - PKCS11Test.getNssConfig: Document CUSTOM_P11_CONFIG properties
>> - Initialize nss_library based on CUSTOM_P11_LIBRARY_NAME
>
> test/jdk/sun/security/pkcs11/PKCS11Test.java line 487:
>
>> 485: String customConfigVariant =
>> System.getProperty("CUSTOM_P11_CONFIG_VARIANT");
>> 486: if (customConfigVariant != null) {
>> 487: // Change, e.g., .../p11-nss.txt to
>> .../p11-nss-sensitive.txt.
>
> nit: be more explicit, e.g. prepend "-sensitive" to the last ".".
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26325#discussion_r2311337004
