On Thu, 16 Oct 2025 19:24:06 GMT, Artur Barashev <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line
>> 251:
>>
>>> 249: // ignore and only log exception
>>> 250: if (SSLLogger.isOn && SSLLogger.isOn("keymanager")) {
>>> 251: SSLLogger.fine("KeyMgr: exception triggered: " + e);
>>
>> I think this should be logged at `warning` level.
>
> Also, `KeyMgr:` string can be removed, the logger will prepend the message
> with the full class name and line number.
I agree with logging this as warning. However I think keeping `KeyMgr:` would
be better, as this format is used in the existing code in the class. What do
you think?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2439693629
