On Tue, 21 Oct 2025 21:26:36 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> In [JDK-8309667](https://bugs.openjdk.org/browse/JDK-8309667), there were >> issues with debugging due to no logging or throwing of errors by >> X509KeyManagerImpl::getEntry. >> [Line](https://github.com/openjdk/jdk/blob/6a4c2676a6378f573bd58d1bc32b57765d756291/src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java#L243-L245) >> >> Extra logging and error propagating should be implemented for the >> X509KeyManagerImpl. >> >> Additionally, dot checking logic has been changed, so no cases similar to >> `.A` will not trigger StringOutOfBounds exceptions. >> >> Thank you @djelinski for finding the issue and analysis. > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > removed log check and renamed logs from keymanager to ssl,keymanager src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 260: > 258: if (SSLLogger.isOn && SSLLogger.isOn("ssl,keymanager")) { > 259: SSLLogger.warning( > 260: "Exception thrown while getting an alias" + This line can be moved up. src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 301: > 299: if (SSLLogger.isOn > 300: && SSLLogger > 301: .isOn("ssl,keymanager")) { This line can be moved up ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2449820495 PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2449819654
