On Wed, 15 Oct 2025 14:26:43 GMT, Artur Barashev <[email protected]> wrote:
>> Hai-May Chao has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Revert changes to UseStrongDHSizes test as ffdhe6144/8192 added back
>> - Updated comment in ServerHello and hybrid to upper-case in NamedGroup
>
> test/jdk/javax/net/ssl/TLSCommon/NamedGroup.java line 44:
>
>> 42: X25519MLKEM768("X25519MLKEM768"),
>> 43: SecP256r1MLKEM768("SecP256r1MLKEM768"),
>> 44: SecP384r1MLKEM1024("SecP384r1MLKEM1024");
>
> Nit: Make those uppercase.
We keep the actual name strings the same as in spec, the enum variables are to
be uppercase for consistency.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2433102109
