On Mon, 27 Oct 2025 02:40:39 GMT, Xue-Lei Andrew Fan <[email protected]> wrote:
>> Hai-May Chao has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Revert changes to UseStrongDHSizes test as ffdhe6144/8192 added back
>> - Updated comment in ServerHello and hybrid to upper-case in NamedGroup
>
> src/java.base/share/classes/sun/security/util/Hybrid.java line 230:
>
>> 228: }
>> 229:
>> 230: throw new InvalidKeySpecException(keySpec.toString());
>
> Please check null keySpec, and `throw new InvalidKeySpecException("keySpec
> must not be null")`.
>
> For non-null keySpec, I may use:
> `throw new InvalidKeySpecException(keySpec.getClass().getName() + " not
> supported.");
> `
Added null `keySpec` check, and updated `InvalidKeySpecException` message.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2505711695
