Hello, D.Yamazaki, Welcome to contributing to JDK. For your patch, please only update the English properties file, I think there is a policy that translations should always be handled by dedicated teams.
I assume you are already familiar with the key sections of the OpenJDK Developers' Guide [1] and the OCA [2]. Thanks, Weijun [1] https://openjdk.org/guide/ [2] https://oca.opensource.oracle.com/?ojr=faq > On Nov 10, 2025, at 14:05, Naoto Sato <[email protected]> wrote: > > I think the common prompt format is [Y/n] or [y/N], where capitalization > indicates the default. That should also have translators not translate it. > (Commenting on it would be safer too) > > Naoto > > On 11/10/25 10:53 AM, Wei-Jun Wang wrote: >> The current code accepts y/n/yes/no (case insensitive) and it's quite good. >> I think modifying the prompts to be clearer is good. >> I'm adding Justin and Naoto here. The current prompts mostly look like >> Do you still want to add it? [no] >> How do you suggest we rewrite it to be more clear on expected inputs? And >> how to avoid translators translating them to localized words like "いいえ" or >> "否"? >> Thanks, >> Weijun >>> On Nov 10, 2025, at 08:22, Alan Bateman <[email protected]> wrote: >>> >>> >>> Adding security-dev to the discussion as keytool is maintained there. >>> >>> On 10/11/2025 12:25, Daisuke Yamazaki wrote: >>>> Hello, >>>> >>>> Currently, keytool accepts input only in English, even though the options >>>> labels are localised. >>>> This raises the question: Should the options also be localised in >>>> accordance >>>> with user's language? >>>> >>>> We basically have two choices: >>>> 1. Localise the options and accept input in the corresponding language >>>> 2. Keep the options uniform in English and accept only English input >>>> >>>> Some languages require input via an IME. For example: >>>> - In japanese, "いいえ" must be typed as "iie". >>>> - In chinese, "否" must be typed as "fou" and then selected from candidates. >>>> >>>> Performing this kind of input can be cumbersome in a console environment, >>>> so I personally prefer the second approach: keeping options in English. >>>> >>>> Currently, some options are incorrectly localized (i.e., the program does >>>> not >>>> accept input in these languages): German, French, Japanese, Korean, >>>> Portuguese (pt_BR), Swedish, Chinese (CN/TW). >>>> >>>> I am planning to create a patch to unify this behavior and would like to >>>> discuss which approach would be preferable. >>>> >>>> Thank you, >>>> D.Yamazaki >>> >
