On Thu, 13 Nov 2025 22:12:06 GMT, Artur Barashev <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 228:
>>
>>> 226: // Logs an info message and always returns false. This method
>>> 227: // can be used as an OR Predicate to add a log in a stream filter.
>>> 228: public static boolean logInfo(String option, String s, Object...
>>> params) {
>>
>> Could you please add tests for this in
>> `test/jdk/sun/security/ssl/SSLLogger`? `loginfo` is not hit by the X509Trust
>> manager and could be reused. The tests could be also added to ssl testing,
>> via `getHostNameInSNI` method
>
> `logInfo` is being called by `X509TrustManagerImpl` actually.
Apologies, I meant the tests. `getHostNameInSNI` itself doesn't seem to be
tested either, so there code will never be tested in the current state. Unless
there is a test, which I'm just missing
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28275#discussion_r2526923721
