On Fri, 14 Nov 2025 10:21:57 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> `logInfo` is being called by `X509TrustManagerImpl` actually. > > Apologies, I meant the tests. `getHostNameInSNI` itself doesn't seem to be > tested either, so there code will never be tested in the current state. > Unless there is a test, which I'm just missing This is just a refactoring PR. Please file a new ticket if you think `getHostNameInSNI` needs a unit test. I think it's better to keep things separate. Refactoring assumes that no new tests needed. Also not sure if we should test new logging methods, I couldn't find any unit tests for existing logging methods. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28275#discussion_r2527702276
