On Mon, 24 Nov 2025 07:51:40 GMT, Hai-May Chao <[email protected]> wrote:
>> Implement hybrid key exchange support for TLS 1.3 by adding three >> post-quantum hybrid named groups: X25519MLKEM768, SecP256r1MLKEM768, and >> SecP384r1MLKEM1024. >> Please see [JEP 527](https://openjdk.org/jeps/527) for details about this >> change. > > Hai-May Chao has updated the pull request incrementally with three additional > commits since the last revision: > > - Update names to uppercase > - Remove fallback in engineGeneratePublic > - Change default named group list to have only X25519MLKEM768 src/java.base/share/classes/sun/security/ssl/NamedGroup.java line 232: > 230: NamedGroupSpec.NAMED_GROUP_KEM, > 231: ProtocolVersion.PROTOCOLS_OF_13, > 232: null), I know the 3 name groups are not used yet, but the name here will be used in the constructor with `KeyFactory.getInstance(name)` and "MLKEM768" is not a standard name. Either use the standard name or do some translation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2557258658
