On Mon, 24 Nov 2025 07:51:40 GMT, Hai-May Chao <[email protected]> wrote:

>> Implement hybrid key exchange support for TLS 1.3 by adding three 
>> post-quantum hybrid named groups: X25519MLKEM768, SecP256r1MLKEM768, and 
>> SecP384r1MLKEM1024.
>> Please see [JEP 527](https://openjdk.org/jeps/527) for details about this 
>> change.
>
> Hai-May Chao has updated the pull request incrementally with three additional 
> commits since the last revision:
> 
>  - Update names to uppercase
>  - Remove fallback in engineGeneratePublic
>  - Change default named group list to have only X25519MLKEM768

test/jdk/javax/net/ssl/TLSv13/HRRKeyShares.java line 1:

> 1: /*

Is the comment on line 352-353 accurate?:


// Now we're expecting to reissue the ClientHello, this time
// with a secp384r1 share.

Shouldn't this be whatever the hrrNamedGroup parameter passed in is?

test/jdk/javax/net/ssl/TLSv13/HRRKeyShares.java line 33:

> 31:  * @summary Use two key share entries
> 32:  * @library /test/lib
> 33:  * @run main/othervm 
> -Djdk.tls.namedGroups=x25519,secp256r1,secp384r1,X25519MLKEM768,SecP256r1MLKEM768,SecP384r1MLKEM1024
>  HRRKeyShares

Long line, break up into multiple lines.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2561620239
PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2561599025

Reply via email to