On Thu, 27 Nov 2025 07:46:46 GMT, Shawn M Emery <[email protected]> wrote:

>> Jiangli Zhou has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Address @smemery's comments:
>>   - Add @requires
>>   - Shorten long lines
>
> test/jdk/com/sun/crypto/provider/Cipher/AES/TestGCMSplitBound.java line 134:
> 
>> 132:             } catch (Exception e) {
>> 133:                 throw new RuntimeException("Failed for messageSize " +
>> 134:                     Integer.toHexString(messageSize), e);
> 
> nit: `+` operator should be first and line indented >= 8 white-spaces.

Aren't these nits something a tool should check and in the best case also fix 
automatically?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28363#discussion_r2567760087

Reply via email to