On Thu, 27 Nov 2025 09:27:04 GMT, Niklas Keller <[email protected]> wrote:
>> test/jdk/com/sun/crypto/provider/Cipher/AES/TestGCMSplitBound.java line 134:
>>
>>> 132: } catch (Exception e) {
>>> 133: throw new RuntimeException("Failed for messageSize " +
>>> 134: Integer.toHexString(messageSize), e);
>>
>> nit: `+` operator should be first and line indented >= 8 white-spaces.
>
> Aren't these nits something a tool should check and in the best case also fix
> automatically?
>> nit: + operator should be first and line indented >= 8 white-spaces.
>
> Aren't these nits something a tool should check and in the best case also fix
> automatically?
Changed to break before operators `+`.
AFAIK, we have mixed styles in existing JDK code with operator on the new line
and operator at the end of previous line for breaking long lines. +1 on the
suggestion to do auto-detection and auto-fix if we want to more strictly
reinforce style.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28363#discussion_r2570569111
