On Tue, 2 Dec 2025 12:30:21 GMT, Mikhail Yankelevich <[email protected]>
wrote:
>> Sergey Chernyshev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - addressed more review comments
>> - addressed review comments
>
> test/jdk/javax/net/ssl/HttpsURLConnection/SubjectAltNameIPv6.java line 32:
>
>> 30: */
>> 31:
>> 32: import javax.net.ssl.*;
>
> nit: wildcard imports
Thanks @myankelev . Done.
> test/jdk/javax/net/ssl/HttpsURLConnection/SubjectAltNameIPv6.java line 50:
>
>> 48: * Turn on SSL debugging?
>> 49: */
>> 50: static boolean debug = false;
>
> Could you please change this to be a env variable? something like
> ```java
> static boolean debug = Boolean.getBoolean("test.debug");
Thanks @myankelev . Accepted.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28577#discussion_r2581412259
PR Review Comment: https://git.openjdk.org/jdk/pull/28577#discussion_r2581412017