On Tue, 2 Dec 2025 15:40:19 GMT, Mikhail Yankelevich <[email protected]>
wrote:
>> Sergey Chernyshev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - addressed more review comments
>> - addressed review comments
>
> test/jdk/javax/net/ssl/HttpsURLConnection/SubjectAltNameIPv6.java line 60:
>
>> 58: * Is the server ready to serve?
>> 59: */
>> 60: volatile static boolean serverReady = false;
>
> I think this might be better to make this a `CountDownLatch`
ok, accepted.
> test/jdk/javax/net/ssl/HttpsURLConnection/SubjectAltNameIPv6.java line 110:
>
>> 108:
>> 109: SSLSocketFactory sf = new
>> SimpleSSLContext().get().getSocketFactory();
>> 110: URL url = new URL("https://[::1]:"; + serverPort +
>> "/index.html");
>
> Suggestion:
>
> URL url =
> new URI("https://[::1]:"; + serverPort + "/index.html").toURL();
I think the block is better readable without it.
> test/jdk/javax/net/ssl/HttpsURLConnection/SubjectAltNameIPv6.java line 165:
>
>> 163:
>> 164: void startServer() throws Exception {
>> 165: serverThread = new Thread() {
>
> Suggestion:
>
> serverThread = new Thread(() -> {
>
> What do you think?
This makes sense. I will set the /contributer manually later.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28577#discussion_r2582027880
PR Review Comment: https://git.openjdk.org/jdk/pull/28577#discussion_r2582024160
PR Review Comment: https://git.openjdk.org/jdk/pull/28577#discussion_r2582019908
