On Wed, 3 Dec 2025 07:28:53 GMT, Daniel Jeliński <[email protected]> wrote:

>> Sergey Chernyshev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   test that ipv4 literals do not propagate to the server names list
>
> test/jdk/javax/net/ssl/HttpsURLConnection/SubjectAltNameIP.java line 105:
> 
>> (failed to retrieve contents of file, check the PR for context)
> Now that you removed the Thread.sleep, you can't close the socket without 
> reading the request off the input stream; it will cause intermittent 
> connection reset failures on Windows. You can use the [readOneRequest 
> method](https://github.com/openjdk/jdk/blob/530493fed4066b1efcf3ec22253b110495767eca/test/jdk/sun/net/www/http/HttpClient/CookieHttpClientTest.java#L77-L89).

Thanks @djelinski for spotting this. Added the method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28577#discussion_r2589187574

Reply via email to