On Thu, 12 Feb 2026 21:05:33 GMT, Artur Barashev <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> rename
>
> src/java.base/share/classes/sun/security/provider/SignatureMessageAccumulator.java
> line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
>
> Should we update the copyright year here and in other files?
Precisely this piece of code was written in 2025 and has not been changed in
2026. Maybe 2025 is the correct year.
> src/java.base/share/classes/sun/security/util/InternalSignatureParameterSpec.java
> line 80:
>
>> 78: * feature strings.
>> 79: *
>> 80: * @param preHash the preHash algorithm to use; {@code null} if none.
>
> Nit: [FIPS 204](https://nvlpubs.nist.gov/nistpubs/fips/nist.fips.204.pdf) is
> using `pre-hash` wording. I think that's what we should use in javadoc and in
> the comments.
OK.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23934#discussion_r2801249605
PR Review Comment: https://git.openjdk.org/jdk/pull/23934#discussion_r2801247720
