On Tue, 24 Mar 2026 14:49:20 GMT, Weijun Wang <[email protected]> wrote:
>> Add a new `SignatureParameterSpec` internal API to fully utilize the >> capabilities of ML-DSA. The updated ACVP test demonstrates its usage. >> >> The new API is internal because it's not yet clear how to provide this >> feature to users. A key should not be shared between plain ML-DSA and >> HashML-DSA, but context can. Features like `internal` and `externalMu` >> should only be used for very special occasions. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > preHash to pre-hash Marked as reviewed by mpowers (Committer). test/jdk/sun/security/provider/ML-DSA/Parameters.java line 39: > 37: import java.security.SignatureException; > 38: > 39: import sun.security.util.SignatureParameterSpec; Is this import necessary? test/jdk/sun/security/provider/acvp/ML_DSA_Test.java line 2: > 1: /* > 2: * Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights > reserved. 2026 ------------- PR Review: https://git.openjdk.org/jdk/pull/23934#pullrequestreview-4009917047 PR Review Comment: https://git.openjdk.org/jdk/pull/23934#discussion_r2991662744 PR Review Comment: https://git.openjdk.org/jdk/pull/23934#discussion_r2991087462
