On Fri, 20 Mar 2026 17:58:39 GMT, Mikhail Yankelevich
<[email protected]> wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update with Mikhail's comments
>
> test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketSSLEngineCloseInbound.java
> line 82:
>
>> 80: * read() ... Finished
>> 81: */
>> 82: import javax.net.ssl.*;
>
> nit: wildcard imports
Done.
> test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketSSLEngineCloseInbound.java
> line 230:
>
>> 228: // server-side socket that will read
>> 229: try (Socket socket = serverSocket.accept()) {
>> 230: socket.setSoTimeout(500);
>
> Suggestion:
>
> socket.setSoTimeout((int)Utils.adjustTimeout(500));
Done.
> test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketSSLEngineCloseInbound.java
> line 350:
>
>> 348: // client-side socket
>> 349: try (SSLSocket sslSocket =
>> (SSLSocket)sslc.getSocketFactory().
>> 350: createSocket("localhost", port)) {
>
> Could you please change this to loopback address since you are touching the
> file?
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30340#discussion_r2978901323
PR Review Comment: https://git.openjdk.org/jdk/pull/30340#discussion_r2978902401
PR Review Comment: https://git.openjdk.org/jdk/pull/30340#discussion_r2978902133
