On Tue, 24 Mar 2026 04:28:24 GMT, Hai-May Chao <[email protected]> wrote:

>> The SSLSocketSSLEngineCloseInbound.java test runs with different protocols, 
>> namely TLSv1.3, TLSv1.2, TLSv1.1, TLSv1, and TLS. The test log file shows 
>> that it completed successfully for the first four protocols, but it failed 
>> when running with protocol=TLS. Protocol TLS is resolved to TLSv1.3. The 
>> failure in the test is a timing-related issue, that server continues with 
>> write() after the client has already closed its side of the connection. This 
>> change removes the race condition by synchronizing the client and server 
>> with CountDownLatch.
>> 
>> Have validated the change to ensure the test to pass (with 
>> JTREG=REPEAT_COUNT=50).
>
> Hai-May Chao has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update with Mikhail's comments

Since you're fixing this in the mainline, and not in the Valhalla repository, 
can you remove the `[lworld]` from the bug title?

test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketSSLEngineCloseInbound.java 
line 31:

> 29: /*
> 30:  * @test
> 31:  * @bug 8273553 8253368 8379549

Please drop the bug ID, and instead add a `noreg-self` label in JBS.

-------------

PR Review: https://git.openjdk.org/jdk/pull/30340#pullrequestreview-3998003358
PR Review Comment: https://git.openjdk.org/jdk/pull/30340#discussion_r2980532223

Reply via email to