On Tue, 28 Apr 2026 13:12:13 GMT, Alan Bateman <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Big facelift
>
> src/java.base/share/classes/javax/net/ssl/SNIHostName.java line 125:
>
>> 123: * @deprecated Users are advised to migrate to the static factory
>> method
>> 124: * {@link #ofHostName(String) SNIHostName.of()}, which performs
>> stricter checks
>> 125: * on the provided hostname.
>
> "Users are advised" is unusual It might be better to have the deprecated
> message be something like "This method is not fully aligned with RFC 6066
> correctly and does not reject a hostname that is an IP literal address. Using
> of(String) instead.".
@AlanBateman Should we leave the method description alone and simply add an
`@deprecated` note here?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3155762314
