> Per [RFC 6066 "3. Server Name Indication"], disallow IP literals in > `SNIHostName::new`. > > While the following two call-sites could be simplified by removing IP literal > checks, I've refrained from doing so because delegating some of the checks to > an exception catching mechanism would impact the performance: > > sun.security.ssl.Utilities::rawToSNIHostName > sun.net.www.protocol.https.HttpsClient::afterConnect > > [RFC 6066 "3. Server Name Indication"]: > https://www.rfc-editor.org/rfc/rfc6066.html#page-6 > > --------- > - [X] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Volkan Yazici has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: - Merge remote-tracking branch 'upstream/master' into sni - Apply review feedback - Fix variable shadowing issue in `SNIHostName` - Enrich tests - Use `sun.security.x509.DNSName` in strict checks - Merge remote-tracking branch 'upstream/master' into sni - Improve deprecation message - Big facelift - Add `ofString` static factory method - Disallow IP literals in `SNIHostName::new` ------------- Changes: - all: https://git.openjdk.org/jdk/pull/30747/files - new: https://git.openjdk.org/jdk/pull/30747/files/31625bf8..f1d1e8b9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=30747&range=08 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30747&range=07-08 Stats: 12545 lines in 275 files changed: 10039 ins; 1249 del; 1257 mod Patch: https://git.openjdk.org/jdk/pull/30747.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/30747/head:pull/30747 PR: https://git.openjdk.org/jdk/pull/30747
