On Wed, 6 May 2026 09:45:04 GMT, Volkan Yazici <[email protected]> wrote:

>> Per [RFC 6066 "3. Server Name Indication"], disallow IP literals in 
>> `SNIHostName::new`.
>> 
>> While the following two call-sites could be simplified by removing IP 
>> literal checks, I've refrained from doing so because delegating some of the 
>> checks to an exception catching mechanism would impact the performance:
>> 
>>     sun.security.ssl.Utilities::rawToSNIHostName
>>     sun.net.www.protocol.https.HttpsClient::afterConnect
>> 
>> [RFC 6066 "3. Server Name Indication"]: 
>> https://www.rfc-editor.org/rfc/rfc6066.html#page-6
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Volkan Yazici has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Do the forgotten update
>  - Improve wording and HTML rendering

There is a difference between `new(String)` and `new(byte[])` in how `encoded` 
is populated. I've added tests and documentation for that in abbb3a3e389.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30747#issuecomment-4405281473

Reply via email to