On Mon, 18 May 2026 17:45:20 GMT, Volkan Yazici <[email protected]> wrote:
>> Per [RFC 6066 "3. Server Name Indication"], disallow IP literals in >> `SNIHostName::new`. >> >> While the following two call-sites could be simplified by removing IP >> literal checks, I've refrained from doing so because delegating some of the >> checks to an exception catching mechanism would impact the performance: >> >> sun.security.ssl.Utilities::rawToSNIHostName >> sun.net.www.protocol.https.HttpsClient::afterConnect >> >> [RFC 6066 "3. Server Name Indication"]: >> https://www.rfc-editor.org/rfc/rfc6066.html#page-6 >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Remove `@apiNote` for `ofHostName` src/java.base/share/classes/javax/net/ssl/SNIHostName.java line 321: > 319: * <ul> > 320: * <li>{@code "example.com".getBytes(US_ASCII)} > 321: * <li>{@code "\u00ebxample.com".getBytes(UTF_8)} — > User-friendly IDN Java source code is in UTF-8, so we can just use `ëxample.com` here and everywhere else in this file. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3261186952
