On Mon, 18 May 2026 20:10:20 GMT, Artur Barashev <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply review feedback > > test/jdk/javax/net/ssl/ServerName/SNIHostNameNegativeTest.java line 1: > >> 1: /* > > We generally try to avoid having separate test classes for positive and for > negative cases. I suggest combining these 2 tests into one, especially since > there is a duplicated code between them. Combined them into one in b68e392b0ab. > test/jdk/javax/net/ssl/ServerName/SNIHostNamePositiveTest.java line 78: > >> 76: new Arg<>(false, "123.com"), >> 77: new Arg<>(false, "a-b-c.com"), >> 78: new Arg<>(false, "\u00ebxample.com"), > > Nit: our current convention is to use UTF-8 in tests instead of Unicode > escape sequences. Replaced Unicode escape sequences with corresponding characters in b68e392b0ab, except for cases where the punycoded translation is a dot — see the `DOTS` constant. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3264873229 PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3264887746
